fix(mcp): disable CDP timeout for extension connection#40265
Merged
yury-s merged 2 commits intomicrosoft:mainfrom Apr 17, 2026
Merged
fix(mcp): disable CDP timeout for extension connection#40265yury-s merged 2 commits intomicrosoft:mainfrom
yury-s merged 2 commits intomicrosoft:mainfrom
Conversation
The extension connection flow requires user interaction (approving the tab in the connect UI). The default 30s CDP timeout is too short and causes spurious failures when the user doesn't approve in time. Pass cdpTimeout from config (defaulting to 0 = no timeout) to match the interactive nature of this flow.
pavelfeldman
approved these changes
Apr 17, 2026
Contributor
Test results for "MCP"1 failed 6095 passed, 976 skipped Merge workflow run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Timeout 30000ms exceedederrors when the user doesn't approve in time.timeout: 0) for the extension flow since it inherently requires user interaction and should not have an arbitrary deadline.