feat(dashboard): save screenshot/recording via Save As dialog#40282
Merged
Conversation
dgozman
approved these changes
Apr 17, 2026
yury-s
approved these changes
Apr 17, 2026
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Screenshot and stop-recording open a native Save As dialog via window.showSaveFilePicker. Recording is streamed to the writable in 256 KB chunks via a new readStream RPC so large recordings don't need to be buffered in base64 over a single WebSocket message. Uses Uint8Array.fromBase64 / toBase64 instead of atob/btoa loops. On EOF or connection close, the fd is closed before unlink so the tmp file is removed on Windows too.
pavelfeldman
force-pushed
the
download_work
branch
from
6a5f1dd to
88d72f7
Compare
Contributor
Test results for "tests 1"3 flaky39196 passed, 847 skipped Merge workflow run. |
Contributor
Test results for "MCP"2 failed 6120 passed, 976 skipped Merge workflow run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
window.showSaveFilePicker).readStreamRPC, so large recordings don't need to be buffered in base64 over a single WebSocket message.