Skip to content

chore(extension): hardcode public key in manifest.json#40288

Merged
yury-s merged 1 commit into
microsoft:mainfrom
yury-s:extension-manifest-key
Apr 17, 2026
Merged

chore(extension): hardcode public key in manifest.json#40288
yury-s merged 1 commit into
microsoft:mainfrom
yury-s:extension-manifest-key

Conversation

@yury-s
Copy link
Copy Markdown
Member

@yury-s yury-s commented Apr 17, 2026

Summary

  • Move extension public key directly into manifest.json instead of injecting it at build time
  • Remove SET_EXTENSION_PUBLIC_KEY_IN_MANIFEST env var from build and CI
  • Simplify extension test fixtures that no longer need to patch the key

Move the extension public key directly into manifest.json instead of
injecting it at build time via SET_EXTENSION_PUBLIC_KEY_IN_MANIFEST.
@yury-s yury-s merged commit 5c49a16 into microsoft:main Apr 17, 2026
32 of 37 checks passed
@yury-s yury-s deleted the extension-manifest-key branch April 17, 2026 22:46
@github-actions
Copy link
Copy Markdown
Contributor

Test results for "tests 1"

1 failed
❌ [playwright-test] › ui-mode-test-network-tab.spec.ts:395 › should copy network request @windows-latest-node20

7 flaky ⚠️ [chromium-library] › library/video.spec.ts:719 › screencast › should work with video+trace `@ubuntu-22.04-chromium-tip-of-tree`
⚠️ [chromium-library] › library/video.spec.ts:719 › screencast › should work with video+trace `@chromium-ubuntu-22.04-arm-node20`
⚠️ [chromium-library] › library/popup.spec.ts:261 › should not throw when click closes popup `@chromium-ubuntu-22.04-node20`
⚠️ [chromium-library] › library/video.spec.ts:647 › screencast › should capture full viewport `@chromium-ubuntu-22.04-node20`
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:1080 › cli codegen › should not throw csp directive violation errors `@firefox-ubuntu-22.04-node20`
⚠️ [firefox-library] › library/inspector/cli-codegen-3.spec.ts:224 › cli codegen › should generate frame locators (4) `@firefox-ubuntu-22.04-node20`
⚠️ [webkit-library] › library/browsercontext-add-cookies.spec.ts:426 › should allow unnamed cookies `@webkit-ubuntu-22.04-node20`

39240 passed, 847 skipped


Merge workflow run.

@github-actions
Copy link
Copy Markdown
Contributor

Test results for "MCP"

13 failed
❌ [chromium] › mcp/cli-json.spec.ts:84 › list after open returns one browser entry @mcp-ubuntu-latest
❌ [chrome] › mcp/cli-json.spec.ts:75 › open returns envelope with session, pid and snapshot file @mcp-windows-latest
❌ [chrome] › mcp/cli-json.spec.ts:103 › goto returns snapshot file envelope @mcp-windows-latest
❌ [chromium] › mcp/cli-json.spec.ts:75 › open returns envelope with session, pid and snapshot file @mcp-windows-latest
❌ [chromium] › mcp/cli-json.spec.ts:84 › list after open returns one browser entry @mcp-windows-latest
❌ [chromium] › mcp/cli-json.spec.ts:103 › goto returns snapshot file envelope @mcp-windows-latest
❌ [firefox] › mcp/cli-json.spec.ts:75 › open returns envelope with session, pid and snapshot file @mcp-windows-latest
❌ [firefox] › mcp/cli-json.spec.ts:103 › goto returns snapshot file envelope @mcp-windows-latest
❌ [chromium] › mcp/cli-json.spec.ts:84 › list after open returns one browser entry @mcp-macos-latest
❌ [webkit] › mcp/cli-json.spec.ts:75 › open returns envelope with session, pid and snapshot file @mcp-windows-latest
❌ [webkit] › mcp/cli-json.spec.ts:103 › goto returns snapshot file envelope @mcp-windows-latest
❌ [msedge] › mcp/cli-json.spec.ts:75 › open returns envelope with session, pid and snapshot file @mcp-windows-latest
❌ [msedge] › mcp/cli-json.spec.ts:103 › goto returns snapshot file envelope @mcp-windows-latest

6382 passed, 976 skipped


Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants