chore(dashboard): enable Vite HMR in watch mode#40327
Merged
Merged
Conversation
yury-s
approved these changes
Apr 21, 2026
Contributor
Test results for "MCP"4 failed 6430 passed, 976 skipped Merge workflow run. |
Contributor
Test results for "tests 1"1 failed 4 flaky39246 passed, 847 skipped Merge workflow run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dashboardApp.ts, so edits topackages/dashboard/src/*reload live when runningnpx playwright show --port=0. Release builds always serve the pre-builtlib/vite/dashboard/static output — the dev-server branch is gated by a compile-time__PW_DASHBOARD_HMR__flag (define) and DCE'd in release.PW_DASHBOARD_STATIC=1opts back into static serving during watch for verifying the bundled output.HttpServer.createWebSocketnow routes HTTP upgrades manually (noServer: true) so Vite's HMR websocket can coexist on the same http.Server — the previous{ server, path }form had thewslibrary aborting non-matching upgrades with 400.DashboardClientContextinto its own module and madecreateRootidempotent soindex.tsxstays a Fast Refresh boundary.