Skip to content

chore(dashboard): remove browser_pick_locator remnants#40351

Merged
Skn0tt merged 1 commit intomicrosoft:mainfrom
Skn0tt:pick-locator-followup
Apr 22, 2026
Merged

chore(dashboard): remove browser_pick_locator remnants#40351
Skn0tt merged 1 commit intomicrosoft:mainfrom
Skn0tt:pick-locator-followup

Conversation

@Skn0tt
Copy link
Copy Markdown
Member

@Skn0tt Skn0tt commented Apr 22, 2026

Summary

  • Remove the browser_pick_locator MCP tool and its test
  • Remove the BrowserContext.pickLocator event end-to-end (protocol, server/client, dispatcher, recorder emit, docs)
  • Remove dead pickLocator/elementPicked plumbing from the dashboard (controller, channel, frontend, icon)
  • Page.pickLocator() / Page.cancelPickLocator() public API is preserved

@Skn0tt Skn0tt requested a review from dgozman April 22, 2026 10:54
@github-actions
Copy link
Copy Markdown
Contributor

Test results for "MCP"

35 failed
❌ [firefox] › mcp/dashboard.spec.ts:312 › should disengage annotate mode when --annotate client disconnects @mcp-windows-latest
❌ [firefox] › mcp/dashboard.spec.ts:394 › stop recording streams WebM bytes to the chosen file @mcp-windows-latest
❌ [webkit] › mcp/cli-devtools.spec.ts:141 › video-start-stop @mcp-windows-latest
❌ [webkit] › mcp/cli-devtools.spec.ts:155 › video-chapter @mcp-windows-latest
❌ [webkit] › mcp/dashboard.spec.ts:121 › daemon show: closing page exits the process @mcp-windows-latest
❌ [webkit] › mcp/dashboard.spec.ts:161 › should capture annotations via show --annotate @mcp-windows-latest
❌ [webkit] › mcp/dashboard.spec.ts:182 › should start dashboard and annotate when no dashboard is running @mcp-windows-latest
❌ [webkit] › mcp/dashboard.spec.ts:204 › should keep CLI annotate engaged across mode switches @mcp-windows-latest
❌ [webkit] › mcp/dashboard.spec.ts:237 › should enter annotate mode on fresh dashboard.tsx mount with -s --annotate @mcp-windows-latest
❌ [webkit] › mcp/dashboard.spec.ts:262 › should switch screencast to -s session on show --annotate @mcp-windows-latest
❌ [webkit] › mcp/dashboard.spec.ts:312 › should disengage annotate mode when --annotate client disconnects @mcp-windows-latest
❌ [webkit] › mcp/dashboard.spec.ts:394 › stop recording streams WebM bytes to the chosen file @mcp-windows-latest
❌ [msedge] › mcp/cli-core.spec.ts:31 › close @mcp-windows-latest
❌ [msedge] › mcp/cli-devtools.spec.ts:141 › video-start-stop @mcp-windows-latest
❌ [msedge] › mcp/cli-devtools.spec.ts:155 › video-chapter @mcp-windows-latest
❌ [msedge] › mcp/cli-json.spec.ts:171 › close after open returns closed status @mcp-windows-latest
❌ [msedge] › mcp/cli-json.spec.ts:177 › close-all after open returns closed sessions @mcp-windows-latest
❌ [msedge] › mcp/cli-session.spec.ts:50 › close @mcp-windows-latest
❌ [msedge] › mcp/cli-session.spec.ts:60 › close named session @mcp-windows-latest
❌ [msedge] › mcp/cli-session.spec.ts:72 › persistent session shows in list after close @mcp-windows-latest
❌ [msedge] › mcp/cli-session.spec.ts:85 › close-all @mcp-windows-latest
❌ [msedge] › mcp/cli-session.spec.ts:99 › delete-data @mcp-windows-latest
❌ [msedge] › mcp/cli-session.spec.ts:111 › delete-data named session @mcp-windows-latest
❌ [msedge] › mcp/cli-session.spec.ts:128 › session stops when browser exits @mcp-windows-latest
❌ [msedge] › mcp/cli-session.spec.ts:142 › session reopen with different config @mcp-windows-latest
❌ [msedge] › mcp/cli-session.spec.ts:159 › workspace isolation - sessions in different workspaces are isolated @mcp-windows-latest
❌ [msedge] › mcp/cli-session.spec.ts:191 › list --all lists sessions from all workspaces @mcp-windows-latest
❌ [msedge] › mcp/dashboard.spec.ts:121 › daemon show: closing page exits the process @mcp-windows-latest
❌ [msedge] › mcp/dashboard.spec.ts:161 › should capture annotations via show --annotate @mcp-windows-latest
❌ [msedge] › mcp/dashboard.spec.ts:182 › should start dashboard and annotate when no dashboard is running @mcp-windows-latest
❌ [msedge] › mcp/dashboard.spec.ts:204 › should keep CLI annotate engaged across mode switches @mcp-windows-latest
❌ [msedge] › mcp/dashboard.spec.ts:237 › should enter annotate mode on fresh dashboard.tsx mount with -s --annotate @mcp-windows-latest
❌ [msedge] › mcp/dashboard.spec.ts:262 › should switch screencast to -s session on show --annotate @mcp-windows-latest
❌ [msedge] › mcp/dashboard.spec.ts:312 › should disengage annotate mode when --annotate client disconnects @mcp-windows-latest
❌ [msedge] › mcp/dashboard.spec.ts:394 › stop recording streams WebM bytes to the chosen file @mcp-windows-latest

5564 passed, 715 skipped


Merge workflow run.

@github-actions
Copy link
Copy Markdown
Contributor

Test results for "tests 1"

7 flaky ⚠️ [chromium-library] › library/browser.spec.ts:73 › newContext should not leave a context upon failure `@ubuntu-22.04-chromium-tip-of-tree`
⚠️ [chromium-library] › library/browser.spec.ts:73 › newContext should not leave a context upon failure `@chromium-ubuntu-22.04-arm-node20`
⚠️ [chromium-library] › library/browser.spec.ts:73 › newContext should not leave a context upon failure `@chromium-ubuntu-22.04-node24`
⚠️ [chromium-library] › library/video.spec.ts:647 › screencast › should capture full viewport `@chromium-ubuntu-22.04-node24`
⚠️ [chromium-library] › library/browser.spec.ts:73 › newContext should not leave a context upon failure `@chromium-ubuntu-22.04-node20`
⚠️ [chromium-library] › library/browser.spec.ts:73 › newContext should not leave a context upon failure `@chromium-ubuntu-22.04-node22`
⚠️ [webkit-library] › library/browser.spec.ts:73 › newContext should not leave a context upon failure `@webkit-ubuntu-22.04-node20`

35889 passed, 679 skipped


Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants