feat(route): expose WebSocket subprotocols on WebSocketRoute#40377
Merged
dgozman merged 1 commit intomicrosoft:mainfrom Apr 23, 2026
Merged
feat(route): expose WebSocket subprotocols on WebSocketRoute#40377dgozman merged 1 commit intomicrosoft:mainfrom
dgozman merged 1 commit intomicrosoft:mainfrom
Conversation
Contributor
Author
|
@microsoft-github-policy-service agree |
rohitpaulk
commented
Apr 23, 2026
|
|
||
| Returns an empty array if no protocols were specified. | ||
|
|
||
| **Usage** |
Contributor
Author
There was a problem hiding this comment.
Wasn't sure if this should go here or at the top, doesn't look like the other methods have usage examples inline.
Adds `WebSocketRoute.protocols(): string[]` so route handlers can read the subprotocols the page passed to `new WebSocket(url, protocols)`. This corresponds to the `Sec-WebSocket-Protocol` request header, which is the only handshake header value page-side JS actually originates.
rohitpaulk
force-pushed
the
add-protocols-to-mock
branch
from
e2d14c6 to
0b43b80
Compare
Contributor
Test results for "MCP"4 failed 6581 passed, 916 skipped Merge workflow run. |
Contributor
Test results for "tests 1"14 flaky41317 passed, 847 skipped Merge workflow run. |
dgozman
approved these changes
Apr 23, 2026
Collaborator
dgozman
left a comment
dgozman
left a comment
There was a problem hiding this comment.
This looks great, thank you for the PR!
Contributor
Author
|
Thanks for the quick merge @dgozman! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #40376
Adds
WebSocketRoute.protocols(): string[]so route handlers can read the subprotocols the page passed tonew WebSocket(url, protocols). This corresponds to theSec-WebSocket-Protocolrequest header, which is the only handshake header value page-side JS actually sets.