feat(extension): redesign connect page#40399
Open
Skn0tt wants to merge 1 commit intomicrosoft:mainfrom
Open
Conversation
Restructure the connect dialog so the heading is prominent, the warning is muted, and a single tab list (with "+ New tab" default) replaces the per-row Allow buttons. The auth token is shown directly with horizontal scroll, and the footer has a primary Allow + ghost Reject. Also enables --debug=cli for the extension test config so the redesign can be visually iterated on while paused.
Member
Author
|
I used our --annotate for this, worked pretty neatly! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--debug=clifor the extension test config (PWTEST_UNDER_TEST=1) so this dialog can be iterated on while paused.Image dropped via the Playwright extension +
playwright cli drop.