fix(mcp): default stdio sessions to isolated#40420
Closed
BaseInfinity wants to merge 2 commits intomicrosoft:mainfrom
Closed
fix(mcp): default stdio sessions to isolated#40420BaseInfinity wants to merge 2 commits intomicrosoft:mainfrom
BaseInfinity wants to merge 2 commits intomicrosoft:mainfrom
Conversation
Author
|
@microsoft-github-policy-service agree |
Member
|
That's unfortunately very breaking. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Default stdio MCP sessions to isolated browser contexts unless the user explicitly opts into persistence or an attached browser mode.
This avoids default-profile
SingletonLockcollisions for short-lived stdio MCP clients after a previous client disconnects without an explicitbrowser_close. HTTP/SSE transports keep the existing persistent default.Fixes #40419.
Changes
browser.isolated = truewhen no persistence or attachment mode is configured.--user-data-dir, remote endpoint, CDP endpoint, extension, and explicit--isolatedbehavior unchanged.Verification
5dafdf939 test(mcp): cover stdio default isolated behavior52afd9c76 fix(mcp): default stdio sessions to isolatednpm run buildnpm run ctest-mcp -- tests/mcp/config-resolve.spec.ts tests/mcp/launch.spec.ts tests/mcp/profile-lock.spec.ts tests/mcp/roots.spec.ts tests/mcp/tabs.spec.ts tests/mcp/tracing.spec.ts87 passed, 1 skippedenv -u NO_COLOR npm run ctest-mcp -- --workers=3589 passed, 3 skippednpm run flintNote: I unset
NO_COLORlocally only to avoid a Node 25 color-environment warning affecting exact-output MCP tests.