Skip to content

chore(electron): polish docs and hide connectToWorker/Worker.disconnect#40483

Merged
dgozman merged 2 commits intomicrosoft:mainfrom
dgozman:electron-and-connect-to-worker
Apr 29, 2026
Merged

chore(electron): polish docs and hide connectToWorker/Worker.disconnect#40483
dgozman merged 2 commits intomicrosoft:mainfrom
dgozman:electron-and-connect-to-worker

Conversation

@dgozman
Copy link
Copy Markdown
Collaborator

@dgozman dgozman commented Apr 29, 2026

Summary

  • Tweaks the v1.59 electron migration notes for clarity.
  • Renames client BrowserType.connectToWorker and Worker.disconnect to _connectToWorker / _disconnect, removes them from the public docs and types. Server-side names and the protocol channel are unchanged.

dgozman added 2 commits April 29, 2026 12:39
Rename client BrowserType.connectToWorker to _connectToWorker and
Worker.disconnect to _disconnect, and drop both from public docs/types.
Keep the server-side names unchanged so the protocol channel is
unaffected. Also tweak electron migration notes.
@github-actions
Copy link
Copy Markdown
Contributor

Test results for "tests 1"

3 flaky ⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:1080 › cli codegen › should not throw csp directive violation errors `@firefox-ubuntu-22.04-node20`
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104 › should work with strict CSP policy `@firefox-ubuntu-22.04-node20`
⚠️ [playwright-test] › ui-mode-trace.spec.ts:700 › should indicate current test status `@windows-latest-node20`

41476 passed, 847 skipped


Merge workflow run.

@github-actions
Copy link
Copy Markdown
Contributor

Test results for "MCP"

11 failed
❌ [chrome] › mcp/autowait.spec.ts:19 › racy navigation destroys context @mcp-windows-latest
❌ [chrome] › mcp/dashboard.spec.ts:185 › should start dashboard and annotate when no dashboard is running @mcp-windows-latest
❌ [chrome] › mcp/dashboard.spec.ts:207 › should enter annotate mode on fresh dashboard.tsx mount with -s --annotate @mcp-windows-latest
❌ [chrome] › mcp/dashboard.spec.ts:231 › should switch screencast to -s session on show --annotate @mcp-windows-latest
❌ [chromium] › mcp/dashboard.spec.ts:185 › should start dashboard and annotate when no dashboard is running @mcp-windows-latest
❌ [chromium] › mcp/dashboard.spec.ts:207 › should enter annotate mode on fresh dashboard.tsx mount with -s --annotate @mcp-windows-latest
❌ [chromium] › mcp/dashboard.spec.ts:231 › should switch screencast to -s session on show --annotate @mcp-windows-latest
❌ [firefox] › mcp/cli-json.spec.ts:177 › close-all after open returns closed sessions @mcp-windows-latest
❌ [firefox] › mcp/cli-session.spec.ts:129 › session reopen with different config @mcp-windows-latest
❌ [firefox] › mcp/network.spec.ts:90 › browser_network_requests numbers requests with stable indexes @mcp-windows-latest
❌ [webkit] › mcp/dashboard.spec.ts:185 › should start dashboard and annotate when no dashboard is running @mcp-macos-latest

1 flaky ⚠️ [chrome] › mcp/cdp.spec.ts:24 › cdp server `@mcp-windows-latest`

6809 passed, 927 skipped


Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants