Skip to content

feat(launchServer): add allowClientNetwork option#40493

Merged
dgozman merged 1 commit intomicrosoft:mainfrom
dgozman:fix-31718
Apr 29, 2026
Merged

feat(launchServer): add allowClientNetwork option#40493
dgozman merged 1 commit intomicrosoft:mainfrom
dgozman:fix-31718

Conversation

@dgozman
Copy link
Copy Markdown
Collaborator

@dgozman dgozman commented Apr 29, 2026

Summary

  • Adds allowClientNetwork to BrowserType.launchServer so a connecting client's exposeNetwork can tunnel browser traffic back through the client. The server pre-launches a SocksProxy with the configured pattern and passes it as preLaunchedSocksProxy to PlaywrightServer, reusing the existing SocksSupportDispatcher pipe.

Fixes #31718

Adds `allowClientNetwork` to `BrowserType.launchServer` so that a connecting
client's `exposeNetwork` can tunnel browser traffic back through the client.
The server pre-launches a SOCKS proxy configured with the pattern and passes
it through to PlaywrightServer as `preLaunchedSocksProxy`.

Fixes microsoft#31718
@github-actions
Copy link
Copy Markdown
Contributor

Test results for "MCP"

2 failed
❌ [chrome] › mcp/cli-session.spec.ts:72 › close-all @mcp-macos-latest-chrome
❌ [webkit] › mcp/dashboard.spec.ts:207 › should enter annotate mode on fresh dashboard.tsx mount with -s --annotate @mcp-macos-latest-webkit

6819 passed, 927 skipped


Merge workflow run.

@github-actions
Copy link
Copy Markdown
Contributor

Test results for "tests 1"

1 failed
❌ [playwright-test] › ui-mode-test-network-tab.spec.ts:395 › should copy network request @windows-latest-node20

4 flaky ⚠️ [chromium-library] › library/popup.spec.ts:261 › should not throw when click closes popup `@chromium-ubuntu-22.04-arm-node20`
⚠️ [chromium-library] › library/video.spec.ts:275 › screencast › should capture navigation `@chromium-ubuntu-22.04-node24`
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:1080 › cli codegen › should not throw csp directive violation errors `@firefox-ubuntu-22.04-node20`
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104 › should work with strict CSP policy `@firefox-ubuntu-22.04-node20`

41537 passed, 784 skipped


Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: launchServer to support exposeNetwork

3 participants