fix(dashboard): handle null viewport in annotate screenshot#40569
Merged
yury-s merged 4 commits intomicrosoft:mainfrom May 1, 2026
Merged
fix(dashboard): handle null viewport in annotate screenshot#40569yury-s merged 4 commits intomicrosoft:mainfrom
yury-s merged 4 commits intomicrosoft:mainfrom
Conversation
Pages whose context was created with viewport: null (e.g. headed playwright-cli open --headed) report viewportSize() as null, which made the annotation modal receive viewportWidth/Height of 0 and silently drop the annotated image. Fall back to window.innerWidth/innerHeight. Fixes: microsoft#40565
documentElement.clientWidth/Height matches the layout viewport that page.screenshot() captures, while window.innerWidth includes scrollbar gutter and would skew annotation scaling.
pavelfeldman
approved these changes
May 1, 2026
This comment has been minimized.
This comment has been minimized.
On Firefox, document.documentElement.clientWidth/clientHeight reflect the rendered content size (e.g. ~8px tall for an empty page), not the live window size. That caused the annotate modal to receive a near-zero viewportHeight, which short-circuited mouse handling so no annotation could be drawn. window.innerWidth/innerHeight match the screenshot dimensions on both engines.
Contributor
Test results for "MCP"1 failed 6875 passed, 1015 skipped Merge workflow run. |
|
Thank you lads ! This feature is crazy thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
playwright-cli open --headedlaunches the browser withviewport: null, which makespage.viewportSize()return null. The dashboard's annotate screenshot then forwardedviewportWidth/Heightof 0, andbuildAnnotatedImagesilently dropped the annotated PNG.window.innerWidth/innerHeightviapage.evaluate()whenviewportSize()is null.Fixes #40565