fix(mcp): propagate abort signal to stop test execution#40582
fix(mcp): propagate abort signal to stop test execution#40582pavelfeldman merged 3 commits intomicrosoft:mainfrom
Conversation
|
|
||
| private _enqueue<T>(fn: () => Promise<T>): Promise<T> { | ||
| const result = this._testOpQueue.then(fn); | ||
| this._testOpQueue = result.then(() => {}, () => {}); |
There was a problem hiding this comment.
This will catch all the errors silently.
There was a problem hiding this comment.
Changed to match the TestRunner.runTests() pattern — single chain with await this._queue, no separate error handler needed since _runTestsImpl has its own try/catch and never rejects.
mxschmitt
force-pushed
the
mxschmitt/fix-38937
branch
from
46b0543 to
1a380e8
Compare
Use single-chain await style matching TestRunner.runTests(), avoiding the empty error handler that looked like it was silently swallowing errors.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Windows CI failures are pre-existing and unrelated to this PR — |
- Simplify _enqueue to match TestRunner queue pattern - Extract signalToPromise utility to @isomorphic/manualPromise
Test results for "MCP"12 failed 6944 passed, 1052 skipped Merge workflow run. |
Test results for "tests 1"1 failed 41661 passed, 851 skipped Merge workflow run. |
2 participants
Summary
AbortSignalfrom MCP SDK throughTestServerBackend→ tool handlers →TestContextrunner.stopTests()and run global teardown before releasing the queueFixes #38937