fix(trace): resolve iframe URLs in trace snapshot CLI#40589
Open
Skn0tt wants to merge 1 commit intomicrosoft:mainfrom
Open
fix(trace): resolve iframe URLs in trace snapshot CLI#40589Skn0tt wants to merge 1 commit intomicrosoft:mainfrom
Skn0tt wants to merge 1 commit intomicrosoft:mainfrom
Conversation
The `trace snapshot` HTTP server hardcoded the top-level pageId for every request and routed `/snapshot` (no trailing slash), so iframe sub-frame requests returned the parent page's snapshot and the renderer's iframe rewrite kept concatenating frame paths instead of finding the prefix. Mirror the trace-viewer service worker: route `/snapshot/`, parse the page-or-frame id from the path, and pass the full URL as the snapshot cache key. Fixes microsoft#40533
Contributor
Test results for "MCP"2 failed 6877 passed, 1025 skipped Merge workflow run. |
pavelfeldman
reviewed
May 4, 2026
| const searchParams = url.searchParams; | ||
| searchParams.set('name', snapshotKey); | ||
| const snapshotResponse = snapshotServer.serveSnapshot(pageId, searchParams, '/snapshot'); | ||
| const snapshotResponse = snapshotServer.serveSnapshot(pageOrFrameId, searchParams, url.href); |
Member
There was a problem hiding this comment.
This is very likely going to explode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
trace snapshotHTTP server hardcoded the top-level pageId and routed/snapshotwithout a trailing slash, so iframe sub-frame requests returned the parent page snapshot and the renderer kept concatenating frame paths./snapshot/, parse the page-or-frame id from the path, and pass the full URL as the snapshot cache key.Fixes #40533