fix(test-runner): race IPv4 and IPv6 webServer port checks#40601
Merged
yury-s merged 1 commit intomicrosoft:mainfrom May 4, 2026
Merged
fix(test-runner): race IPv4 and IPv6 webServer port checks#40601yury-s merged 1 commit intomicrosoft:mainfrom
yury-s merged 1 commit intomicrosoft:mainfrom
Conversation
Previously the IPv4 (127.0.0.1) and IPv6 (::1) port checks ran sequentially: if the first call hung, the second would not start until it timed out. Race them in parallel instead — return true as soon as either succeeds, and false only after both fail. Fixes: microsoft#40430
pavelfeldman
approved these changes
May 4, 2026
This comment has been minimized.
This comment has been minimized.
Contributor
Test results for "tests 1"5 flaky41639 passed, 784 skipped Merge workflow run. |
Contributor
Test results for "MCP"6876 passed, 1015 skipped Merge workflow run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
trueas soon as either check succeeds; resolvefalseonly once both have failed.Fixes #40430