Skip to content

docs(locator): fix hideHighlight/highlight examples#40602

Merged
pavelfeldman merged 1 commit intomicrosoft:mainfrom
pavelfeldman:docs-locator-highlight-fixes
May 4, 2026
Merged

docs(locator): fix hideHighlight/highlight examples#40602
pavelfeldman merged 1 commit intomicrosoft:mainfrom
pavelfeldman:docs-locator-highlight-fixes

Conversation

@pavelfeldman
Copy link
Copy Markdown
Member

Summary

  • Rewrite the garbled Locator.hideHighlight description.
  • Fix the Locator.highlight example to use the { style } options object.
  • Tighten the style object value type from any to string | number.

- Rewrite the garbled `Locator.hideHighlight` description.
- Fix the `Locator.highlight` example to use the `{ style }` options
  object instead of passing the value directly.
- Tighten the `style` object value type from `any` to `string | number`.
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 4, 2026

Test results for "MCP"

15 failed
❌ [firefox] › mcp/cli-session.spec.ts:44 › close named session @mcp-windows-latest-firefox
❌ [firefox] › mcp/cli-session.spec.ts:130 › workspace isolation - sessions in different workspaces are isolated @mcp-windows-latest-firefox
❌ [firefox] › mcp/dashboard.spec.ts:124 › daemon show: closing page exits the process @mcp-windows-latest-firefox
❌ [firefox] › mcp/dashboard.spec.ts:165 › should capture annotations via show --annotate @mcp-windows-latest-firefox
❌ [firefox] › mcp/dashboard.spec.ts:186 › should start dashboard and annotate when no dashboard is running @mcp-windows-latest-firefox
❌ [firefox] › mcp/dashboard.spec.ts:208 › should enter annotate mode on fresh dashboard.tsx mount with annotate @mcp-windows-latest-firefox
❌ [firefox] › mcp/dashboard.spec.ts:232 › should annotate via direct browser_annotate MCP call @mcp-windows-latest-firefox
❌ [firefox] › mcp/dashboard.spec.ts:265 › should annotate when context has no fixed viewport @mcp-windows-latest-firefox
❌ [firefox] › mcp/dashboard.spec.ts:302 › should cancel browser_annotate when the MCP request is aborted @mcp-windows-latest-firefox
❌ [firefox] › mcp/dashboard.spec.ts:333 › should cancel browser_annotate when the MCP client disconnects @mcp-windows-latest-firefox
❌ [firefox] › mcp/dashboard.spec.ts:362 › should switch screencast to -s session on show --annotate @mcp-windows-latest-firefox
❌ [firefox] › mcp/dashboard.spec.ts:411 › should disengage annotate mode when --annotate client disconnects @mcp-windows-latest-firefox
❌ [firefox] › mcp/dashboard.spec.ts:478 › save recording streams WebM bytes to the chosen file @mcp-windows-latest-firefox
❌ [msedge] › mcp/cli-storage.spec.ts:61 › state-load restores storage state from file @mcp-windows-latest-msedge
❌ [msedge] › mcp/cli-storage.spec.ts:100 › state-save and state-load roundtrip @mcp-windows-latest-msedge

6861 passed, 1015 skipped


Merge workflow run.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 4, 2026

Test results for "tests 1"

2 flaky ⚠️ [chromium-library] › library/beforeunload.spec.ts:130 › should support dismissing the dialog multiple times `@chromium-ubuntu-22.04-arm-node20`
⚠️ [chromium-library] › library/video.spec.ts:719 › screencast › should work with video+trace `@chromium-ubuntu-22.04-arm-node20`

41642 passed, 784 skipped


Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants