Skip to content

feat(api): unify WebError and ConsoleMessage location#40606

Merged
yury-s merged 1 commit intomicrosoft:mainfrom
yury-s:feat-location-line-column
May 4, 2026
Merged

feat(api): unify WebError and ConsoleMessage location#40606
yury-s merged 1 commit intomicrosoft:mainfrom
yury-s:feat-location-line-column

Conversation

@yury-s
Copy link
Copy Markdown
Member

@yury-s yury-s commented May 4, 2026

Summary

  • WebError.location now returns an Object with url/line/column in all languages (was a string in java/csharp).
  • ConsoleMessage.location() exposes line/column; lineNumber/columnNumber are kept as deprecated aliases.

- WebError.location now returns an Object with url/line/column in all
  languages (previously a string in java/csharp).
- ConsoleMessage.location() exposes line/column alongside the now
  deprecated lineNumber/columnNumber.
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 4, 2026

Test results for "MCP"

19 failed
❌ [chrome] › mcp/autowait.spec.ts:19 › racy navigation destroys context @mcp-windows-latest-chrome
❌ [chrome] › mcp/cli-storage.spec.ts:61 › state-load restores storage state from file @mcp-windows-latest-chrome
❌ [chrome] › mcp/cli-storage.spec.ts:100 › state-save and state-load roundtrip @mcp-windows-latest-chrome
❌ [chrome] › mcp/config.ini.spec.ts:57 › ini config sets browser launch options @mcp-windows-latest-chrome
❌ [chromium] › mcp/http.spec.ts:103 › http transport browser lifecycle (isolated) @mcp-windows-latest-chromium
❌ [chromium] › mcp/http.spec.ts:142 › http transport browser sigint @mcp-windows-latest-chromium
❌ [firefox] › mcp/cli-devtools.spec.ts:217 › video-start-stop @mcp-windows-latest-firefox
❌ [firefox] › mcp/cli-devtools.spec.ts:231 › video-chapter @mcp-windows-latest-firefox
❌ [firefox] › mcp/dashboard.spec.ts:124 › daemon show: closing page exits the process @mcp-windows-latest-firefox
❌ [firefox] › mcp/dashboard.spec.ts:165 › should capture annotations via show --annotate @mcp-windows-latest-firefox
❌ [firefox] › mcp/dashboard.spec.ts:186 › should start dashboard and annotate when no dashboard is running @mcp-windows-latest-firefox
❌ [firefox] › mcp/dashboard.spec.ts:208 › should enter annotate mode on fresh dashboard.tsx mount with annotate @mcp-windows-latest-firefox
❌ [firefox] › mcp/dashboard.spec.ts:232 › should annotate via direct browser_annotate MCP call @mcp-windows-latest-firefox
❌ [firefox] › mcp/dashboard.spec.ts:265 › should annotate when context has no fixed viewport @mcp-windows-latest-firefox
❌ [firefox] › mcp/dashboard.spec.ts:302 › should cancel browser_annotate when the MCP request is aborted @mcp-windows-latest-firefox
❌ [firefox] › mcp/dashboard.spec.ts:333 › should cancel browser_annotate when the MCP client disconnects @mcp-windows-latest-firefox
❌ [firefox] › mcp/dashboard.spec.ts:362 › should switch screencast to -s session on show --annotate @mcp-windows-latest-firefox
❌ [firefox] › mcp/dashboard.spec.ts:411 › should disengage annotate mode when --annotate client disconnects @mcp-windows-latest-firefox
❌ [firefox] › mcp/dashboard.spec.ts:478 › save recording streams WebM bytes to the chosen file @mcp-windows-latest-firefox

1 flaky ⚠️ [chrome] › mcp/cdp.spec.ts:24 › cdp server `@mcp-windows-latest-chrome`

6856 passed, 1015 skipped


Merge workflow run.

@yury-s yury-s merged commit 0435fae into microsoft:main May 4, 2026
41 of 44 checks passed
@yury-s yury-s deleted the feat-location-line-column branch May 4, 2026 18:58
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 4, 2026

Test results for "tests 1"

4 flaky ⚠️ [chromium-library] › library/video.spec.ts:719 › screencast › should work with video+trace `@chromium-ubuntu-22.04-arm-node20`
⚠️ [chromium-library] › library/video.spec.ts:275 › screencast › should capture navigation `@chromium-ubuntu-22.04-node24`
⚠️ [chromium-library] › library/video.spec.ts:719 › screencast › should work with video+trace `@chromium-ubuntu-22.04-node20`
⚠️ [chromium-library] › library/video.spec.ts:476 › screencast › should capture static page in persistent context @smoke `@chromium-ubuntu-22.04-node22`

41640 passed, 784 skipped


Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants