Skip to content

fix(mcp): anchor aria-ref regex in target resolution#40610

Merged
yury-s merged 2 commits intomicrosoft:mainfrom
yury-s:fix-mcp-1600
May 4, 2026
Merged

fix(mcp): anchor aria-ref regex in target resolution#40610
yury-s merged 2 commits intomicrosoft:mainfrom
yury-s:fix-mcp-1600

Conversation

@yury-s
Copy link
Copy Markdown
Member

@yury-s yury-s commented May 4, 2026

Summary

  • Anchor the aria-ref detection regex so locators like id=z2l9e43l3 (which contain e\d+ substrings) are no longer misclassified as aria-refs.

Fixes microsoft/playwright-mcp#1600

@yury-s yury-s merged commit 7579e1b into microsoft:main May 4, 2026
42 of 44 checks passed
@yury-s yury-s deleted the fix-mcp-1600 branch May 4, 2026 19:47
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 4, 2026

Test results for "MCP"

8 failed
❌ [firefox] › mcp/cli-drag.spec.ts:53 › drop files and data onto an element @mcp-windows-latest-firefox
❌ [firefox] › mcp/cli-isolated.spec.ts:21 › should not save user data by default (in-memory mode) @mcp-windows-latest-firefox
❌ [firefox] › mcp/cli-json.spec.ts:75 › open returns envelope with session, pid and snapshot file @mcp-windows-latest-firefox
❌ [firefox] › mcp/cli-json.spec.ts:84 › list after open returns one browser entry @mcp-windows-latest-firefox
❌ [firefox] › mcp/cli-json.spec.ts:103 › goto returns snapshot file envelope @mcp-windows-latest-firefox
❌ [firefox] › mcp/cli-json.spec.ts:109 › eval returns result string @mcp-windows-latest-firefox
❌ [firefox] › mcp/http.spec.ts:103 › http transport browser lifecycle (isolated) @mcp-windows-latest-firefox
❌ [firefox] › mcp/http.spec.ts:142 › http transport browser sigint @mcp-windows-latest-firefox

6881 passed, 1015 skipped


Merge workflow run.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 4, 2026

Test results for "tests 1"

4 flaky ⚠️ [chromium-library] › library/video.spec.ts:647 › screencast › should capture full viewport `@chromium-ubuntu-22.04-node24`
⚠️ [chromium-library] › library/video.spec.ts:682 › screencast › should capture full viewport on hidpi `@chromium-ubuntu-22.04-node24`
⚠️ [chromium-library] › library/video.spec.ts:719 › screencast › should work with video+trace `@chromium-ubuntu-22.04-node24`
⚠️ [chromium-library] › library/video.spec.ts:647 › screencast › should capture full viewport `@chromium-ubuntu-22.04-node22`

41577 passed, 847 skipped


Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: target aria-ref pattern matching is overly broad

2 participants