Skip to content

Revert "fix(mcp): handle page crash event in Tab constructor"#40619

Merged
pavelfeldman merged 1 commit intomainfrom
revert-40426-fix/mcp-tab-crash-handler
May 5, 2026
Merged

Revert "fix(mcp): handle page crash event in Tab constructor"#40619
pavelfeldman merged 1 commit intomainfrom
revert-40426-fix/mcp-tab-crash-handler

Conversation

@pavelfeldman
Copy link
Copy Markdown
Member

Reverts #40426 - I did not mean to land a failing test.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 5, 2026

Test results for "MCP"

5 failed
❌ [chrome] › mcp/dashboard.spec.ts:207 › should enter annotate mode on fresh dashboard.tsx mount with -s --annotate @mcp-windows-latest-chrome
❌ [chrome] › mcp/dashboard.spec.ts:231 › should annotate via direct browser_annotate MCP call @mcp-windows-latest-chrome
❌ [chrome] › mcp/dashboard.spec.ts:264 › should annotate when context has no fixed viewport @mcp-windows-latest-chrome
❌ [chrome] › mcp/dashboard.spec.ts:301 › should cancel browser_annotate when the MCP request is aborted @mcp-windows-latest-chrome
❌ [chrome] › mcp/dashboard.spec.ts:361 › should switch screencast to -s session on show --annotate @mcp-windows-latest-chrome

6887 passed, 1025 skipped


Merge workflow run.

@pavelfeldman pavelfeldman merged commit 9ed57f1 into main May 5, 2026
17 of 18 checks passed
@pavelfeldman pavelfeldman deleted the revert-40426-fix/mcp-tab-crash-handler branch May 5, 2026 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants