Skip to content

fix(security): prevent Zip Slip path traversal in harUnzip #40623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pavelfeldman merged 1 commit into from
May 6, 2026
+5 −2
Merged

fix(security): prevent Zip Slip path traversal in harUnzip #40623

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions packages/playwright-core/src/server/localUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ import { serializeClientSideCallMetadata } from '@isomorphic/trace/traceUtils';
import { assert } from '@isomorphic/assert';
import { calculateSha1 } from '@utils/crypto';
import { ZipFile } from '@utils/zipFile';
import { removeFolders } from '@utils/fileUtils';
import { removeFolders, resolveWithinRoot } from '@utils/fileUtils';
import { HarBackend } from './harBackend';
import type * as channels from '@protocol/channels';
import type * as har from '@trace/har';
Expand Down Expand Up @@ -187,7 +187,10 @@ export async function harUnzip(progress: Progress, params: channels.LocalUtilsHa
await progress.race(fs.promises.mkdir(resourcesDir, { recursive: true }));
resourcesDirCreated = true;
}
await progress.race(fs.promises.writeFile(path.join(resourcesDir, entry), buffer));
const outPath = resolveWithinRoot(resourcesDir, entry);
if (!outPath)
throw new Error(`HAR zip entry '${entry}' escapes output directory`);
await progress.race(fs.promises.writeFile(outPath, buffer));
}
}
await progress.race(fs.promises.unlink(params.zipFile));
Expand Down
Loading