Skip to content

fix(yauzl): vendor yauzl with destroy-lifecycle fix#40747

Merged
pavelfeldman merged 1 commit into
microsoft:mainfrom
pavelfeldman:chore-vendor-yauzl-with-destroy-fix
May 9, 2026
Merged

fix(yauzl): vendor yauzl with destroy-lifecycle fix#40747
pavelfeldman merged 1 commit into
microsoft:mainfrom
pavelfeldman:chore-vendor-yauzl-with-destroy-fix

Conversation

@pavelfeldman
Copy link
Copy Markdown
Member

@pavelfeldman pavelfeldman commented May 9, 2026 •
edited
Loading

Summary

  • Vendor yauzl 3.2.1 + fd-slicer/pend/buffer-crc32 into packages/utils/third_party/yauzl/, drop the npm dep.
  • Apply yauzl#168 to fd-slicer's ReadStream/WriteStream so _destroy(err, cb) drives the lifecycle and 'close' fires after EOF — async iteration (for await) over openReadStream no longer hangs on modern Node.

Fixes: #40724
Courtesy @seia-soto

@pavelfeldman
chore(yauzl): vendor yauzl with destroy-lifecycle fix
1b44506 
Vendor yauzl 3.2.1 (plus its fd-slicer/pend/buffer-crc32 deps) into
packages/utils/third_party/yauzl/, and apply the fix from
thejoshwolfe/yauzl#168 to fd-slicer's
ReadStream/WriteStream destroy() lifecycle so that 'close' is emitted
after EOF and `for await` over openReadStream completes on modern Node.
@pavelfeldman pavelfeldman changed the title chore(yauzl): vendor yauzl with destroy-lifecycle fix fix(yauzl): vendor yauzl with destroy-lifecycle fix May 9, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 9, 2026

Test results for "MCP"

11 failed
❌ [chrome] › mcp/annotate.spec.ts:137 › should abort MCP annotation when last screenshot is removed @mcp-windows-latest-chrome
❌ [chrome] › mcp/annotate.spec.ts:398 › should cancel browser_annotate when the MCP client disconnects @mcp-windows-latest-chrome
❌ [firefox] › mcp/annotate.spec.ts:273 › should enter annotate mode on fresh dashboard.tsx mount with -s --annotate @mcp-windows-latest-firefox
❌ [firefox] › mcp/annotate.spec.ts:297 › should annotate via direct browser_annotate MCP call @mcp-windows-latest-firefox
❌ [firefox] › mcp/annotate.spec.ts:330 › should annotate when context has no fixed viewport @mcp-windows-latest-firefox
❌ [firefox] › mcp/annotate.spec.ts:367 › should cancel browser_annotate when the MCP request is aborted @mcp-windows-latest-firefox
❌ [firefox] › mcp/annotate.spec.ts:398 › should cancel browser_annotate when the MCP client disconnects @mcp-windows-latest-firefox
❌ [firefox] › mcp/annotate.spec.ts:427 › should switch screencast to -s session on show --annotate @mcp-windows-latest-firefox
❌ [firefox] › mcp/annotate.spec.ts:476 › should disengage annotate mode when --annotate client disconnects @mcp-windows-latest-firefox
❌ [firefox] › mcp/cli-devtools.spec.ts:217 › video-start-stop @mcp-windows-latest-firefox
❌ [firefox] › mcp/cli-devtools.spec.ts:231 › video-chapter @mcp-windows-latest-firefox

7020 passed, 1068 skipped

Merge workflow run.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 9, 2026

Test results for "tests 1"

1 failed
❌ [playwright-test] › playwright.trace.spec.ts:346 › should retain traces for interrupted tests @windows-latest-node20

6 flaky ⚠️ [installation tests] › playwright-test-package-managers.spec.ts:19 › npm: @playwright/test should work `@package-installations-windows-latest`
⚠️ [chromium-library] › library/video.spec.ts:719 › screencast › should work with video+trace `@chromium-ubuntu-22.04-arm-node20`
⚠️ [chromium-library] › library/video.spec.ts:337 › screencast › should work for popups `@chromium-ubuntu-22.04-node24`
⚠️ [webkit-library] › library/browsertype-connect.spec.ts:776 › launchServer › should upload a folder `@webkit-ubuntu-22.04-node20`
⚠️ [webkit-page] › page/page-set-input-files.spec.ts:38 › should upload a folder `@webkit-ubuntu-22.04-node20`
⚠️ [playwright-test] › ui-mode-trace.spec.ts:812 › should update state on subsequent run `@windows-latest-node20`

41699 passed, 850 skipped

Merge workflow run.

yury-s
yury-s approved these changes May 9, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@yury-s yury-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd just wait for it to land upstream.

@pavelfeldman pavelfeldman merged commit c17e0b4 into microsoft:main May 9, 2026
42 of 45 checks passed
@ThomasK33 ThomasK33 mentioned this pull request May 11, 2026
Merged
yury-s pushed a commit that referenced this pull request May 11, 2026
@pavelfeldman @yury-s
cherry-pick(#40747): fix(yauzl): vendor yauzl with destroy-lifecycle fix
87bb9dd
@sixtyfive sixtyfive mentioned this pull request May 14, 2026
Closed
@jzeng151 jzeng151 mentioned this pull request May 20, 2026
Open
4 tasks
@hubertgajewski hubertgajewski mentioned this pull request May 21, 2026
Closed
10 tasks
@lpsinger lpsinger mentioned this pull request May 22, 2026
Merged
@seia-soto
Copy link
Copy Markdown

seia-soto commented May 22, 2026

@pavelfeldman I'm letting you know that the upstream released a fix. I don't know if playwright team sees dropping vendored code good or not. Imo, it's better to get the upstream code instead and get the future updates in that way along with the fix. The patch applied here is small enough to fix the issue.

dakota002 pushed a commit to nasa-gcn/gcn.nasa.gov that referenced this pull request May 22, 2026
@lpsinger
Update playwright to 1.60.0
aee42fc 
This fixes hangs when installing Playwright browsers on Node 26.
See microsoft/playwright#40724,
microsoft/playwright#40747.
@MikeMcC399 MikeMcC399 mentioned this pull request May 23, 2026
Open
@fengmk2 fengmk2 mentioned this pull request May 24, 2026
Merged
This was referenced May 24, 2026
Closed
Merged
@dkoo761 dkoo761 mentioned this pull request May 26, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dcrousso dcrousso dcrousso approved these changes

@yury-s yury-s yury-s approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: playwright install hangs in node v26

4 participants

@pavelfeldman @seia-soto @dcrousso @yury-s