fix(dashboard): clean up temp recording directory on close#40751
Merged
pavelfeldman merged 1 commit intomicrosoft:mainfrom May 9, 2026
Merged
Conversation
DashboardConnection creates a temp directory for recordings via mkdtempSync but never removes it when the connection closes. Clean up the directory in onclose to avoid orphaned temp files. Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
pavelfeldman
approved these changes
May 9, 2026
Contributor
Test results for "MCP"1 failed 7043 passed, 1068 skipped Merge workflow run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DashboardConnectioncreates a temp directory for recordings viamkdtempSyncbut never removes it when the connection closesoncloseto avoid orphaned temp filesFailure scenario: Each dashboard WebSocket connection creates a
playwright-recordings-*temp directory. When the connection closes, individual stream files are cleaned up but the directory itself persists. On long-running servers with many dashboard sessions, this accumulates orphaned directories in the system temp folder.Origin: The recording directory was introduced in #40279 (2026-04-17) by Pavel Feldman.