test: fix flaky 'should filter actions by text'#40804
Merged
Merged
Conversation
The test reads `fullCount = actionTitles.count()` immediately after the
trace viewer loads, but actions are streamed asynchronously. On slow
runners (macOS 26, webkit-windows) `fullCount` could be 0, making the
subsequent `toBeLessThan(fullCount)` impossible. Wait for the last
recorded action ('Close page') to be visible before counting.
pavelfeldman
approved these changes
May 12, 2026
Contributor
Test results for "MCP"3 failed 7067 passed, 1068 skipped Merge workflow run. |
Contributor
Test results for "tests 1"1 failed 3 flaky41756 passed, 850 skipped Merge workflow run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fullCount = actionTitles.count()right after the trace viewer loads, but actions render asynchronously. On slow runners (macOS 26, webkit/win)fullCountwas sometimes0, making the subsequenttoBeLessThan(fullCount)impossible (Expected: < 0, Received: 1).Close page) to be visible before counting.