chore(dispatcher): move potentiallyClosesScope into protocol metainfo#40833
Merged
dgozman merged 1 commit intoMay 14, 2026
Merged
Conversation
Make `potentiallyClosesScope` a flag on protocol methods in protocol.yml, generate it into protocolMetainfo, and consult it solely from dispatcher.ts. Removes the field from CallMetadata and drops the per-dispatcher assignments. While there, `Frame.expect` no longer needs the flag: it already converts any thrown error (including TargetClosedError) into an ExpectResult.
Contributor
Test results for "MCP"5 failed 7081 passed, 1104 skipped Merge workflow run. |
Contributor
Test results for "tests 1"2 flaky41770 passed, 850 skipped Merge workflow run. |
pavelfeldman
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
potentiallyClosesScopea flag on protocol methods inprotocol.yml, generated intoprotocolMetainfo, and consulted solely fromdispatcher.ts.CallMetadataand drop the per-dispatcherprogress.metadata.potentiallyClosesScope = trueassignments.Frame.expectno longer needs the flag: it already converts any thrown error (includingTargetClosedError) into anExpectResult.