Skip to content

docs(cli-client/skill): fix small typos in skill references#40942

Merged
dgozman merged 1 commit into
microsoft:mainfrom
AllDmeat:fix/typos-in-cli-client-skill-references
May 22, 2026
Merged

docs(cli-client/skill): fix small typos in skill references#40942
dgozman merged 1 commit into
microsoft:mainfrom
AllDmeat:fix/typos-in-cli-client-skill-references

Conversation

@AllDmeat
Copy link
Copy Markdown
Contributor

Originally opened against microsoft/playwright-cli#412; @dgozman pointed out the source of truth lives here, redoing the PR against this repo.

Small fixes in packages/playwright-core/src/tools/cli-client/skill/references/:

  • spec-driven-testing.md — example test group name was 'Singing in and out', changed to 'Signing in and out'.
  • storage-state.md — both the expires example in the storage-state JSON (line 41) and the --expires example for cookie-set (line 95) used Unix timestamp 1735689600, which is Jan 1 2025 — already in the past, making the cookie examples read as expired. Bumped both to 1893456000 (Jan 1 2030).
  • video-recording.md — "pulling appropriate pauses between the actions" → "inserting appropriate pauses".

No behavior changes — docs only.

- spec-driven-testing.md: `Singing in and out` → `Signing in and out`
- storage-state.md: bump example cookie `expires` from 1735689600
  (Jan 1, 2025) to 1893456000 (Jan 1, 2030) so the example doesn't
  read as already-expired
- video-recording.md: `pulling appropriate pauses` → `inserting
  appropriate pauses`

Same fixes were originally opened as microsoft/playwright-cli#412;
@dgozman pointed out this is the source of truth, redoing it here.
@github-actions
Copy link
Copy Markdown
Contributor

Test results for "MCP"

2 failed
❌ [chrome] › mcp/annotate.spec.ts:331 › should annotate when context has no fixed viewport @mcp-windows-latest-chrome
❌ [chrome] › mcp/annotate.spec.ts:368 › should cancel browser_annotate when the MCP request is aborted @mcp-windows-latest-chrome

7179 passed, 1113 skipped


Merge workflow run.

Copy link
Copy Markdown
Collaborator

@dgozman dgozman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you.

@dgozman dgozman merged commit a052a36 into microsoft:main May 22, 2026
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants