chore(bidi): emit load events after browsingContext.create#40944
Merged
Conversation
21e3403 to
b611c55
Compare
dgozman
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to the Bidi spec, no
browsingContext.domContentLoadedandbrowsingContext.loadevents should be fired for new browsing contexts until they navigate away fromabout:blank(both Chrome's and Firefox's implementations are now aligned with this). But the Playwright API expects these events even forabout:blank.With this PR Playwright emits the
domcontentloadedandloadevents afterbrowsingContext.createreturns.Note that this doesn't fix the issue for iframes and popups because when Playwright receives the
browsingContext.contextCreatedevent it is impossible to tell if the iframe/popup will navigate away fromabout:blank(in which casebrowsingContext.domContentLoadedandbrowsingContext.loadwill be fired after the navigation) or not (in which case no other events will be fired), see this spec issue.Fixes the following tests: