fix(reporter): print inline failure for non-retriable errors#41026
Merged
Conversation
The list reporter's printFailuresInline relies on willRetry() to decide whether to print a failure now or wait for the retry. willRetry() only looked at the retry budget and did not account for non-retriable errors (e.g. a missing snapshot that was just written), which are never retried. As a result the failure was neither printed inline nor in the suppressed epilogue, so the error body was dropped from the output entirely. Surface the non-retriable flag onto the test result (live and blob paths) and consult it in willRetry().
The golden for "should work with file path" was missing for the webkit-webview project, causing the test to fail in CI.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
The list reporter's printFailuresInline consulted willRetry() to decide whether to print a failure now. Instead, print whenever the current result is itself a failure (status differs from expected and is not skipped). This no longer depends on predicting retries, so non-retriable failures are printed reliably.
pavelfeldman
approved these changes
May 28, 2026
Contributor
Test results for "MCP"1 failed 7206 passed, 1113 skipped Merge workflow run. |
Contributor
Test results for "tests 1"4 flaky43968 passed, 864 skipped Merge workflow run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
listreporter'sprintFailuresInlineconsultedwillRetry()to decide whether to print a failure inline.willRetry()only checked the retry budget, so non-retriable failures (e.g. a missing snapshot that was just written) were neither printed inline nor in the suppressed epilogue — the error body was dropped entirely.willRetry().