fix(tools): pass time parameter to page.evaluate in waitForTimeout#41037
Merged
pavelfeldman merged 1 commit intoMay 29, 2026
Merged
Conversation
waitForTimeout(time) had two branches: the blocked-path branch correctly used the time parameter, but the normal path hardcoded 1000ms. All callers pass 500, so every waitForCompletion cycle waited 2x longer than intended. This was introduced in microsoft#37286 when MCP tools were moved into the monorepo. Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
pavelfeldman
approved these changes
May 28, 2026
Contributor
Test results for "MCP"1 failed 7206 passed, 1113 skipped Merge workflow run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
waitForTimeout(time)has two branches:timeparameter1000ms, ignoringtimeBoth callers in
utils.tspass500, so everywaitForCompletioncycle (click, fill, navigate, and other interactive tools) waits 1000ms instead of the intended 500ms. This adds an unnecessary 500ms to each tool call.The fix passes the
timeparameter through topage.evaluate, making the normal path consistent with the blocked path.Before:
After:
This was introduced in #37286 when MCP tools were moved into the monorepo.