chore: consolidate vite SW+main builds via Environment API#41047
Merged
Conversation
The trace-viewer and extension packages each had a separate vite.sw.config for the service worker build, spawned as its own 'vite build --watch' process. Use Vite 6's Environment API to build both environments from a single Vite process per package, reducing the dev-time process count from 7 to 5.
Contributor
Test results for "MCP"7207 passed, 1113 skipped Merge workflow run. |
Contributor
Test results for "tests 1"2 flaky43984 passed, 864 skipped Merge workflow run. |
pavelfeldman
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vite.sw.config.{ts,mts}in trace-viewer and extension; their config is nowenvironments.swin the mainvite.config.