test(webview): add a timeout for clearCookies in teardown so a busy page can't stall it#41416
Open
dcrousso wants to merge 1 commit into
Open
test(webview): add a timeout for clearCookies in teardown so a busy page can't stall it#41416dcrousso wants to merge 1 commit into
clearCookies in teardown so a busy page can't stall it#41416dcrousso wants to merge 1 commit into
Conversation
… page can't stall it `tests/page/page-set-content.spec.ts:153:3 › should handle timeout properly` will infinitely loop the page as a result, none of the WebKit inspector protocol messages are handled `context.clearCookies` performs multiple round-trips using the WebKit inspector protocol (`Page.getCookies` and then `Page.deleteCookie` for each) when the page is busy, we will end up waiting indefinitely
This was referenced Jun 23, 2026
Contributor
Test results for "MCP"7380 passed, 1122 skipped Merge workflow run. |
Contributor
Test results for "tests 1"3 failed 4 flaky48925 passed, 1142 skipped Merge workflow run. |
| // The shared Mobile Safari cookie store persists across tests; clear it | ||
| // while still on the test's domain (webview cookies are domain-scoped). | ||
| await page.context().clearCookies().catch(() => {}); | ||
| await Promise.race([ |
Member
There was a problem hiding this comment.
Sounds like the fix should be in clearCookies()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tests/page/page-set-content.spec.ts:153:3 › should handle timeout properlywill infinitely loop the pageas a result, none of the WebKit inspector protocol messages are handled
context.clearCookiesperforms multiple round-trips using the WebKit inspector protocol (Page.getCookiesand thenPage.deleteCookiefor each)when the page is busy, we will end up waiting indefinitely