fix(mcp): close isolated HTTP client context on disconnect#41560
Merged
Conversation
In --isolated mode each HTTP client gets its own browser context, but the disposed callback returned early while other clients were connected, leaking the disconnected client's context until the last client left. Close the per-client context immediately on disconnect; shared contexts stay open. Fixes: microsoft#41539
Contributor
Test results for "MCP"7461 passed, 1132 skipped Merge workflow run. |
yury-s
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--isolatedmode each HTTP client owns its own browser context, but thedisposedcallback returned early while other clients were still connected, leaking the disconnected client's context until the last client left.--shared-browser-context) still stays open for remaining clients, and the browser is closed only when the last client leaves.Fixes #41539