chore(locator): reimplement waitForFunction via _callOnElementOnceMatches#41611
Merged
Conversation
…ches
Base Locator.waitForFunction on a dedicated server method built on
_callOnElementOnceMatches instead of overloading waitForFunctionExpression.
_callOnElementOnceMatches now keeps polling while the callback returns a
falsy value; existing callers wrap their return in { result } so a
legitimately-falsy value still resolves immediately.
Contributor
Test results for "MCP"1 failed 7642 passed, 1132 skipped Merge workflow run. |
Contributor
Test results for "tests 1"2 flaky49496 passed, 1164 skipped Merge workflow run. |
Skn0tt
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Locator.waitForFunctionon a dedicated server method (Frame.waitForFunctionExpressionOnElement) built on_callOnElementOnceMatches, instead of overloadingFrame.waitForFunctionExpression._callOnElementOnceMatchesnow keeps polling while the callback returns a falsy value; all existing callers wrap their return in{ result }so a legitimately-falsy value still resolves immediately.Frame.waitForFunctionExpressionto its selector-free form.