test(mcp): de-flake webkit dashboard CLI tests#41649
Merged
Merged
Conversation
Two MCP CLI tests flaked on the webkit CI shard: - annotate.spec.ts "should capture annotations via show --annotate" hit the 30s test timeout inside connectToDashboard's unbounded toPass on slow webkit startup. Mark it test.slow(), matching the sibling dashboard tests in the file. - cli-killall.spec.ts "kill-all kills filtered dashboard pid" observed a live daemon 1ms before kill-all, yet kill-all reported "No daemon processes found". kill-all discovery is best-effort (ps auxww via execSync, failures swallowed), so retry until it observes and kills it.
yury-s
commented
Jul 6, 2026
| }); | ||
| expect(output).toContain(`Killed daemon process ${dashboardPid}`); | ||
| expect(output).toContain('Killed 1 daemon process.'); | ||
| // kill-all discovers daemons via `execSync('ps auxww')` and treats any failure |
Member
Author
There was a problem hiding this comment.
I'm not confident that it is what actually happens, but it is worth trying.
Contributor
Test results for "MCP"7643 passed, 1132 skipped Merge workflow run. |
pavelfeldman
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
annotate.spec.ts"should capture annotations via show --annotate" hit the 30s test timeout insideconnectToDashboard's unboundedtoPasson slow webkit startup — mark ittest.slow(), matching the sibling dashboard tests in the file.cli-killall.spec.ts"kill-all kills filtered dashboard pid" observed a live daemon 1ms beforekill-all, yetkill-allreported "No daemon processes found". Its discovery is best-effort (ps auxwwviaexecSync, failures swallowed), so retry until it observes and kills the daemon.Both surfaced as flakes on the
macos-latest - webkitMCP shard.