Add additional solution packaging parameters #202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tehcrashxor
approved these changes
Apr 21, 2022
davidjenni
suggested changes
Apr 22, 2022
davidjenni
approved these changes
Apr 25, 2022
Contributor
davidjenni
left a comment
davidjenni
left a comment
There was a problem hiding this comment.
I prefer any drastic whitespace or quoting changes to be separate, non-functionality impact changes (i.e. anything that goes beyond a few opportunistic fixups), since it adds a lot of diff noise.
I know the existing .editorconfig VS Code extension doesn't have the ability to preset per-repo styling settings like quotes (we liberally use that in VS for C#), but I think there is a way to have per-repo VSCode settings we can checkin to better control consistency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump version of PP-CLI-Wrapper to x.49
Note that use of single quotes is a non-default option in VS Code
Should potentially be enforced with a style check if single is preferred over double quotes.