Conversation
|
/azp run |
|
Thanks! We'll review this shortly. Please also add the new entities to docs/supported_entities.md |
|
Azure Pipelines successfully started running 1 pipeline(s). |
omri374
left a comment
omri374
left a comment
There was a problem hiding this comment.
Thanks! Left some minor comments.
| from presidio_analyzer import Pattern, PatternRecognizer | ||
|
|
||
|
|
||
| class EtIkRecognizer(PatternRecognizer): |
There was a problem hiding this comment.
Can we / should we create a class which supports all those entities with the same logic, and have the different specific country implementations inherit those? What are your thoughts?
| ), | ||
| ] | ||
|
|
||
| CONTEXT = ["asmens kodas"] |
There was a problem hiding this comment.
The current implementation of context works better with unigrams. Can we separate this into "asmens", "kodas" or one of those, in addition to the existing "asmens kodas"?
| ("37102250382", 1, ((0, 11),),), | ||
| # invalid identity card scores | ||
| ("37132250382", 0, ()), | ||
| ("99999999999", 0, ()), |
There was a problem hiding this comment.
Please add a test case with surrounding text
| ("33309240064", 1, ((0, 11),),), | ||
| # invalid identity card scores | ||
| ("33309240063", 0, ()), | ||
| ("99999999999", 0, ()), |
There was a problem hiding this comment.
Same here, please add a test case with surrounding text
|
@bckamil are you interested in completing this PR? |
2 participants
Change Description
Added:
You can verify recognizers using:
Checklist