Skip to content

Fix PhoneRecognizer default regions typo: "FE" → "FR"#2009

Merged
SharonHart merged 2 commits into
mainfrom
copilot/fix-phone-recognizer-typo
Apr 30, 2026
Merged

Fix PhoneRecognizer default regions typo: "FE" → "FR"#2009
SharonHart merged 2 commits into
mainfrom
copilot/fix-phone-recognizer-typo

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 30, 2026

PhoneRecognizer.DEFAULT_SUPPORTED_REGIONS contained "FE" (not a valid ISO country code) instead of "FR" (France), silently skipping French phone number detection for all default recognizer instances.

Changes

  • phone_recognizer.py: Fix "FE""FR" in DEFAULT_SUPPORTED_REGIONS
  • test_phone_recognizer.py: Add test case asserting French numbers are detected and labeled as FR region

Example

from presidio_analyzer.predefined_recognizers.generic.phone_recognizer import PhoneRecognizer

reco = PhoneRecognizer()
results = reco.analyze("Mon numéro est +33 1 42 68 53 00.", ["PHONE_NUMBER"], nlp_artifacts=None)
# Before: []
# After:  [RecognizerResult(entity_type=PHONE_NUMBER, ... explanation="Recognized as FR region phone number")]

Copilot AI changed the title [WIP] Fix typo in PhoneRecognizer default regions for French numbers Fix PhoneRecognizer default regions typo: "FE" → "FR" Apr 30, 2026
Copilot AI requested a review from omri374 April 30, 2026 03:57
@omri374 omri374 marked this pull request as ready for review April 30, 2026 05:09
@omri374 omri374 requested a review from SharonHart April 30, 2026 05:09
@github-actions
Copy link
Copy Markdown

Coverage report (presidio-anonymizer)

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  presidio-anonymizer/presidio_anonymizer
  anonymizer_engine.py
Project Total  

This report was generated by python-coverage-comment-action

@github-actions
Copy link
Copy Markdown

Coverage report (presidio-cli)

This PR does not seem to contain any modification to coverable code.

@github-actions
Copy link
Copy Markdown

Coverage report (presidio-structured)

This PR does not seem to contain any modification to coverable code.

@github-actions
Copy link
Copy Markdown

Coverage report (presidio-image-redactor)

This PR does not seem to contain any modification to coverable code.

@github-actions
Copy link
Copy Markdown

Coverage report (presidio-analyzer)

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  presidio-analyzer/presidio_analyzer/nlp_engine
  __init__.py
  nlp_engine_provider.py
  presidio-analyzer/presidio_analyzer/predefined_recognizers
  __init__.py
  presidio-analyzer/presidio_analyzer/predefined_recognizers/country_specific
  __init__.py
  presidio-analyzer/presidio_analyzer/predefined_recognizers/country_specific/germany
  de_bsnr_recognizer.py
  de_id_card_recognizer.py
  de_lanr_recognizer.py
  de_passport_recognizer.py
  de_social_security_recognizer.py
  de_tax_id_recognizer.py
  de_vat_id_recognizer.py
  presidio-analyzer/presidio_analyzer/predefined_recognizers/country_specific/poland
  pl_pesel_recognizer.py
  presidio-analyzer/presidio_analyzer/predefined_recognizers/country_specific/uk
  __init__.py
  presidio-analyzer/presidio_analyzer/predefined_recognizers/generic
  phone_recognizer.py
Project Total  

This report was generated by python-coverage-comment-action

@SharonHart SharonHart merged commit 2f9c1ff into main Apr 30, 2026
35 checks passed
@SharonHart SharonHart deleted the copilot/fix-phone-recognizer-typo branch April 30, 2026 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PhoneRecognizer default regions contain typo "FE" — French phone numbers not detected

3 participants