Skip to content

Initial dynamic_list support#764

Merged
chjinche merged 5 commits intomainfrom
chjinche/dynamic_list
Oct 23, 2023
Merged

Initial dynamic_list support#764
chjinche merged 5 commits intomainfrom
chjinche/dynamic_list

Conversation

@chjinche
Copy link
Copy Markdown
Contributor

@chjinche chjinche commented Oct 13, 2023 •
edited
Loading

Description

Implementing dynamic_list contract to unlock the scenario that any tool should be able to define the listing experience and the corresponding request to enable the dynamic listing feature. See more in #383

In this PR, we did following things:

  • implement gen_dynamic_list in tools_manager.
  • append ws triple to function input params, as user may call azure control plane api in the custom function to list Azure resources.
  • add an example tool with dynamic list input to my_tool_package.

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@chjinche chjinche requested a review from a team as a code owner October 13, 2023 10:48
@chjinche chjinche temporarily deployed to internal October 13, 2023 10:48 — with GitHub Actions Inactive
@chjinche chjinche temporarily deployed to internal October 13, 2023 10:48 — with GitHub Actions Inactive
@chjinche chjinche temporarily deployed to internal October 13, 2023 10:48 — with GitHub Actions Inactive
@chjinche chjinche temporarily deployed to internal October 13, 2023 10:48 — with GitHub Actions Inactive
@chjinche chjinche temporarily deployed to internal October 13, 2023 10:48 — with GitHub Actions Inactive
@github-actions github-actions Bot added sdk prompt flow SDK promptflow labels Oct 13, 2023
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 13, 2023 •
edited
Loading

SDK CLI Global Config Test Result chjinche/dynamic_list

2 tests   2 ✔️  1m 3s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit d4fa89c.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 13, 2023 •
edited
Loading

Executor Unit Test Result chjinche/dynamic_list

    2 files      2 suites   2m 17s ⏱️
386 tests 385 ✔️ 1 💤 0 ❌
750 runs  747 ✔️ 3 💤 0 ❌

Results for commit d4fa89c.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 13, 2023 •
edited
Loading

SDK PFS E2E Test Result chjinche/dynamic_list

8 tests   8 ✔️  29s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit d4fa89c.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 13, 2023 •
edited
Loading

Executor E2E Test Result chjinche/dynamic_list

    2 files      2 suites   22m 45s ⏱️
105 tests 103 ✔️ 2 💤 0 ❌
210 runs  204 ✔️ 6 💤 0 ❌

Results for commit d4fa89c.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 13, 2023 •
edited
Loading

SDK CLI Test Result chjinche/dynamic_list

    2 files      2 suites   30m 2s ⏱️
305 tests 292 ✔️ 13 💤 0 ❌
610 runs  584 ✔️ 26 💤 0 ❌

Results for commit d4fa89c.

♻️ This comment has been updated with latest results.

@chjinche chjinche temporarily deployed to internal October 16, 2023 10:29 — with GitHub Actions Inactive
@chjinche chjinche temporarily deployed to internal October 16, 2023 10:29 — with GitHub Actions Inactive
@chjinche chjinche temporarily deployed to internal October 16, 2023 10:29 — with GitHub Actions Inactive
@chjinche chjinche temporarily deployed to internal October 16, 2023 10:29 — with GitHub Actions Inactive
@chjinche chjinche temporarily deployed to internal October 16, 2023 10:29 — with GitHub Actions Inactive
chjinche
chjinche commented Oct 16, 2023
View reviewed changes
Comment thread src/promptflow/promptflow/_sdk/_utils.py Outdated
@chjinche chjinche temporarily deployed to internal October 17, 2023 12:12 — with GitHub Actions Inactive
@chjinche chjinche temporarily deployed to internal October 17, 2023 12:12 — with GitHub Actions Inactive
@chjinche chjinche temporarily deployed to internal October 17, 2023 12:12 — with GitHub Actions Inactive
@chjinche chjinche temporarily deployed to internal October 17, 2023 12:12 — with GitHub Actions Inactive
@chjinche chjinche temporarily deployed to internal October 17, 2023 12:12 — with GitHub Actions Inactive
@github-actions github-actions Bot added the examples Improvements on examples label Oct 17, 2023
@chjinche chjinche temporarily deployed to internal October 18, 2023 08:24 — with GitHub Actions Inactive
@chjinche chjinche temporarily deployed to internal October 18, 2023 08:24 — with GitHub Actions Inactive
@chjinche chjinche temporarily deployed to internal October 18, 2023 08:24 — with GitHub Actions Inactive
@chjinche chjinche temporarily deployed to internal October 20, 2023 13:03 — with GitHub Actions Inactive
@chjinche chjinche temporarily deployed to internal October 20, 2023 13:03 — with GitHub Actions Inactive
@chjinche chjinche temporarily deployed to internal October 20, 2023 13:03 — with GitHub Actions Inactive
@chjinche chjinche temporarily deployed to internal October 20, 2023 13:03 — with GitHub Actions Inactive
@chjinche chjinche temporarily deployed to internal October 20, 2023 13:03 — with GitHub Actions Inactive
@chjinche chjinche temporarily deployed to internal October 20, 2023 13:12 — with GitHub Actions Inactive
@chjinche chjinche temporarily deployed to internal October 20, 2023 13:12 — with GitHub Actions Inactive
@chjinche chjinche temporarily deployed to internal October 20, 2023 13:12 — with GitHub Actions Inactive
@chjinche chjinche temporarily deployed to internal October 20, 2023 13:12 — with GitHub Actions Inactive
@chjinche chjinche temporarily deployed to internal October 20, 2023 13:12 — with GitHub Actions Inactive
@chjinche chjinche requested a review from chenslucky October 20, 2023 13:13
@chjinche chjinche linked an issue Oct 20, 2023 that may be closed by this pull request
[Feature Request] Dynamic list capability support in tool contract #383
Closed
@chjinche chjinche requested a review from thy09 October 23, 2023 02:28
thy09
thy09 previously approved these changes Oct 23, 2023
View reviewed changes
brynn-code
brynn-code previously approved these changes Oct 23, 2023
View reviewed changes
@chjinche chjinche dismissed stale reviews from brynn-code and thy09 via d4fa89c October 23, 2023 07:14
@chjinche chjinche temporarily deployed to internal October 23, 2023 07:14 — with GitHub Actions Inactive
@chjinche chjinche temporarily deployed to internal October 23, 2023 07:14 — with GitHub Actions Inactive
@chjinche chjinche temporarily deployed to internal October 23, 2023 07:14 — with GitHub Actions Inactive
@chjinche chjinche temporarily deployed to internal October 23, 2023 07:14 — with GitHub Actions Inactive
@chjinche chjinche temporarily deployed to internal October 23, 2023 07:14 — with GitHub Actions Inactive
@chjinche chjinche merged commit 50c7721 into main Oct 23, 2023
@chjinche chjinche deleted the chjinche/dynamic_list branch October 23, 2023 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brynn-code brynn-code brynn-code approved these changes

@naiyunzhang naiyunzhang naiyunzhang approved these changes

@chenslucky chenslucky Awaiting requested review from chenslucky

+1 more reviewer

@thy09 thy09 thy09 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

examples Improvements on examples promptflow sdk prompt flow SDK

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature Request] Dynamic list capability support in tool contract

4 participants

@chjinche @thy09 @brynn-code @naiyunzhang