CMake package name and target namespace mismatch

[SidneyCogdill]

FYI: https://www.kitware.com/psa-your-package-name-and-target-namespace-should-match/ (I named the target namespace wrongly and didn't follow the best practices).

Currently:

• Proxy 3:
  • package is found via find_package(proxy CONFIG REQUIRED)
  • there is no target namespace
  • there is target msft_proxy
• Proxy 4:
  • package is found via find_package(proxy4 CONFIG REQUIRED)
  • the target namespace is msft_proxy
  • there are targets msft_proxy::proxy4 and msft_proxy::proxy4_module

Making changes to Proxy 3 probably isn't feasible at this point, but since Proxy 4 haven't been released yet, I think Proxy 4 should be updated to follow the best practices before its release.

Some random ideas:

• find_package(msft_proxy4 CONFIG REQUIRED)
  target name: msft_proxy4::proxy, msft_proxy4::proxy_module
• find_package(MicrosoftProxy4 CONFIG REQUIRED)
  target name: MicrosoftProxy4::Proxy, MicrosoftProxy4::ProxyModule
• find_package(proxy4 CONFIG REQUIRED)
  target name: proxy4::proxy, proxy4::module

[SidneyCogdill]

the microsoft/GSL library uses this (Microsoft.PackageName):

find_package(Microsoft.GSL CONFIG REQUIRED)

target_link_libraries(foobar PRIVATE Microsoft.GSL::GSL)

Maybe:

find_package(Microsoft.Proxy4 CONFIG REQUIRED)
Microsoft.Proxy4::Proxy, Microsoft.Proxy4::ProxyModule ?

[mingxwa]

Hi @SidneyCogdill, thank you for the thoughtful write-up and for highlighting the CMake guidance. I agree that aligning the package name and target namespace is important, especially before Proxy 4 is released. I prefer:

find_package(msft_proxy4 CONFIG REQUIRED)
target_link_libraries(foobar PRIVATE msft_proxy4::proxy)

It keeps things consistent with the existing msft_proxy naming while setting a clear path forward for versioning. If this goes well, I plan to backport the change to Proxy 3.4.0 as well. I've already forked a branch release/3.4.0 and cherry-picked a bunch of commits. So we'd eventually have msft_proxy3 and msft_proxy4 following the same convention.