Skip to content

fix connection checks for draggable shadows #10352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
riknoll merged 1 commit into from
Jan 27, 2025
Merged

fix connection checks for draggable shadows #10352

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions pxtblocks/plugins/duplicateOnDrag/connectionChecker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import * as Blockly from "blockly";
import { shouldDuplicateOnDrag } from "./duplicateOnDrag";
import { isAllowlistedShadow, shouldDuplicateOnDrag } from "./duplicateOnDrag";


const OPPOSITE_TYPE: number[] = [];
Expand All @@ -16,7 +16,13 @@ export class DuplicateOnDragConnectionChecker extends Blockly.ConnectionChecker

const replacedBlock = b.targetBlock();

if (replacedBlock && shouldDuplicateOnDrag(replacedBlock)) return false;
if (
replacedBlock &&
shouldDuplicateOnDrag(replacedBlock) &&
!(replacedBlock.isShadow() && isAllowlistedShadow(replacedBlock))
) {
return false;
}

return true;
}
Expand Down
Loading