Fix legacy source-map compatibility issue with browserify#10572
Merged
eanders-ms merged 2 commits intomasterfrom May 9, 2025
Merged
Fix legacy source-map compatibility issue with browserify#10572eanders-ms merged 2 commits intomasterfrom
eanders-ms merged 2 commits intomasterfrom
Conversation
riknoll
approved these changes
May 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After upgrading Node.js from v18 to v22, running
gulpbegan failing with the following error:This error originates from
combine-source-map, a transitive dependency ofbrowserify, which relies on an internalbase64VLQAPI that was only available insource-map@0.4.x.During the Node upgrade,
node_moduleswas reinstalled, andcombine-source-mappicked up a newersource-map@0.5.7, which no longer exposesbase64VLQ. This caused the internal call to fail at runtime.Solution
Added a targeted override to
package.jsonto forcecombine-source-mapto usesource-map@0.4.4, which restores compatibility:This restores the build without needing to update (or swap out) browserify.