fix render of youtube links and images in docs pages#11105
Merged
Conversation
srietkerk
reviewed
Feb 12, 2026
| "outFiles": [] | ||
| }, | ||
| { | ||
| "name": "pxt serve (core)", |
Contributor
There was a problem hiding this comment.
Are these launch changes intentionally included?
Member
Author
There was a problem hiding this comment.
yup, we didn't have one for debugging core docs
srietkerk
approved these changes
Feb 12, 2026
abchatra
pushed a commit
that referenced
this pull request
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixing a couple of regressions caused by the recent marked/sanitize-html upgrades
we embed youtube videos for youtube links that are alone on a line in a markdown page. the marked upgrade broke this behavior because it was generating slightly different html that tripped up our big macro regex that replaces the generated html with the thumbnail embed
sanitize-html was also stripping all images from the generated html because img isn't in the default list of allowed tags
@ganicke FYI!