Skip to content

a few fixes for gallery tilemaps#11125

Merged
riknoll merged 1 commit intomasterfrom
dev/riknoll/arcade-gallery-tilemaps-should-not-copy-tiles
Feb 18, 2026
Merged

a few fixes for gallery tilemaps#11125
riknoll merged 1 commit intomasterfrom
dev/riknoll/arcade-gallery-tilemaps-should-not-copy-tiles

Conversation

@riknoll
Copy link
Member

@riknoll riknoll commented Feb 18, 2026

three fixes:

  • my earlier change broke the tilemap gallery, so fixing that boolean expression
  • fixed a random null pointer exception that i noticed sometimes occurs in new projects. it had to do with the tileset field editor not initializing its asset change listener before the constructor ran
  • added some code to prevent gallery tiles from being added to your "my tiles" section when selecting a tilemap from the gallery

the third one is in response to multiple people on the forum thinking this was a bug instead of an intentional choice (and i agree with them)

@riknoll riknoll requested a review from a team February 18, 2026 19:26
@riknoll riknoll enabled auto-merge (squash) February 18, 2026 19:30
}

if (tile.bitmap) {
if (tile.meta.tags?.some(t => t.startsWith("category-") || BUILTIN_CATEGORIES.some(c => c.id === t))) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reservations about this change. I do agree that there is a bug with duplicates.. If you select a tilemap with dungeon tiles multiple times, it will continue to add stuff to your "my tiles". I also understand that it would be frustrating to get random tiles in "my tiles" while just checking out the gallery for fun. In these ways I agree that there should be a fix.

However, what if you're a somewhat new user and select a tilemap from the gallery to get started with and eventually want to add or make changes to that tilemap? There is a lot of context a user would have to gather to see the tiles that are getting used and then make the additions.

I'm fine with making this change for now, but I think this needs some rework. Maybe we need another tab or something that has "used tiles" for a tilemap that you're on currently? Or maybe in My Assets we include the tiles from the tilemap itself?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

used tiles isn't a bad idea, but i don't think you ever want gallery tiles duplicated in my tiles; especially since it essentially buries any tiles you've already added to your project. another fix could be to make the eye dropper tool more prominent (right now it's hidden behind holding down the alt key).

adding tiles to your my tiles section just seems wrong to me; it's like that time apple made everyone download that U2 album onto their ipods

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

regardless, i think it's more annoying than helpful right now

@riknoll riknoll merged commit e3d0868 into master Feb 18, 2026
20 checks passed
@riknoll riknoll deleted the dev/riknoll/arcade-gallery-tilemaps-should-not-copy-tiles branch February 18, 2026 21:22
riknoll added a commit that referenced this pull request Feb 18, 2026
riknoll added a commit that referenced this pull request Feb 18, 2026
* put imported tiles into a custom tilemap gallery (#11112)

* allow users to delete project descriptions (#11113)

* fix font for animation icon in animation field editor (#11114)

* copilot generated: add media queries for print view (#11110)

* fix tile gallery not showing up when editing tile (#11115)

* prevent debugger toolbox from scrolling horizontally (#11120)

* Fix blockly dropdown scroll and media not being copied properly (#11119)

* add scroll to blockly dropdown content

* fix piping of blockly media files

* keep the error list collapsed if collapsed by user (#11121)

* add monkey patch workaround for blockly focus issue when deleting block (#11122)

* bring back the old mixer play instructions (#11123)

* fix missing gallery, don't import gallery tiles into my tiles, fix null listener (#11125)

---------

Co-authored-by: Sarah Rietkerk <49178322+srietkerk@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments