Use an actual percentage for progress bar when flashing#11186
Merged
riknoll merged 2 commits intomicrosoft:masterfrom Mar 11, 2026
Merged
Use an actual percentage for progress bar when flashing#11186riknoll merged 2 commits intomicrosoft:masterfrom
riknoll merged 2 commits intomicrosoft:masterfrom
Conversation
NVDA uses sound to communicate progress, but this does not work with fractional values.
riknoll
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NVDA uses sound to communicate progress, but this does not work with fractional values (0-1). I've tried to make the progress bar more consistent in always using a percentage from 0-100.
The value that is passed to different instances of the progress element is inconsistent. In some places a percentage is passed in. In other cases, a fractional value is passed in. Both appear to have been done with purpose.
loadedPercentageis actually a fractional value here (Is this always the case? What about other hardware?) so the use of percent in the name here and on the outside is confusing, but I've not attempted to change that in this PR.