Improve the simulator live region#11275
Open
microbit-robert wants to merge 1 commit intomicrosoft:masterfrom
Open
Improve the simulator live region#11275microbit-robert wants to merge 1 commit intomicrosoft:masterfrom
microbit-robert wants to merge 1 commit intomicrosoft:masterfrom
Conversation
The live region is re-created if required. There is code in the sim that clears the DOM. The same message can be announced more than once with the addition of a non-breaking space.
riknoll
requested changes
Apr 29, 2026
| liveRegion.textContent = value; | ||
| if (value) { | ||
| /* eslint-disable @microsoft/sdl/no-inner-html */ | ||
| liveRegion.innerHTML = `<p>${value}${addNonBreakingSpace ? ' ' : ''}</p>`; |
Member
There was a problem hiding this comment.
let's not use innerhtml here.. are we certain that everything being passed to this function is sanitized? if someone were to, say, pass a malicious string with html into our localization pipeline somehow would they be able to inject some code?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The live region is re-created if required. There is code in the sim that can clear the DOM.
The same message can be announced more than once with the addition (toggling) of a non-breaking space.