Merged
Conversation
jwunderl
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is now far enough along to check in! definitely not finished, but it works!
this is an alternate "piano roll" style song editor. the intention here is not to replace the current song editor, but to provide another interface that some people might find more familiar. also, this UI scales down much better than our current editor. if we wanted to have a song editor that fit in a blockly dropdown style editor (like sound effects or melodies), this would fit much more easily.
i mainly want this for arcade because people complain about the limitations of the current editor, but this will probably be relegated to an extension instead of the default music category. definitely targets more advanced users.
advantages over the current song editor:
disadvantages over the current song editor:
the two editors share lots of code! the song format for serializing/deserializing is the same for both so no changes are needed on the pxt-common-packages side