Skip to content

add high contrast override for ch-added class#11306

Merged
srietkerk merged 5 commits into
masterfrom
srietkerk/hc-tutorial-highlight
May 14, 2026
Merged

add high contrast override for ch-added class#11306
srietkerk merged 5 commits into
masterfrom
srietkerk/hc-tutorial-highlight

Conversation

@srietkerk
Copy link
Copy Markdown
Contributor

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to improve the High Contrast color theme’s readability for GitHub “update” diffs by adding a CSS override for inline added chunks (.ch-added) inside table.diffview.update (fixing microsoft/pxt-microbit#6775).

Changes:

  • Add a High Contrast override targeting table.diffview.update .diff-added .ch-added.
  • Force inline-added chunk text and outline color to use --pxt-neutral-background1.

Comment thread theme/color-themes/overrides/high-contrast-overrides.css Outdated
Copy link
Copy Markdown
Member

@riknoll riknoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a css file, not a less file. you can't nest rules in pure css

@srietkerk srietkerk enabled auto-merge (squash) May 14, 2026 18:29
@srietkerk srietkerk merged commit 719e235 into master May 14, 2026
20 checks passed
@srietkerk srietkerk deleted the srietkerk/hc-tutorial-highlight branch May 14, 2026 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hot Potato Game Tutorial: Yellow Hint Code Highlights Have Poor Visibility in High Contrast Mode

4 participants