Ipad toolbox bug fixes#11333
Open
srietkerk wants to merge 4 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes iPad/touch interaction regressions in the MakeCode toolbox and Monaco flyout after recent keyboard navigation changes.
Changes:
- Restores a guard in toolbox focus handling to avoid re-selecting an already selected category.
- Adds touch/pen
pointeruphandling for Monaco toolbox category selection. - Adds
pointerupfocus handling for Monaco flyout blocks when not dragging.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
webapp/src/toolbox.tsx |
Updates toolbox focus behavior and adds Monaco-only pointer-up category selection. |
webapp/src/monacoFlyout.tsx |
Adds pointer-up focus behavior for flyout block taps. |
| ref={handleRef} | ||
| onFocus={() => this.handleFocus(qName)} | ||
| onClick={() => buttonRef && buttonRef.focus()} | ||
| onPointerUp={() => { if (!this.dragging && buttonRef) buttonRef.focus(); }} |
riknoll
requested changes
May 28, 2026
Member
riknoll
left a comment
riknoll
left a comment
There was a problem hiding this comment.
i don't think we should revert this focus change. instead, let's figure out why the check on line 500 isn't triggering correctly on ipad
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes microsoft/pxt-microbit#6802
Fixes microsoft/pxt-microbit#6799
Fixes microsoft/pxt-microbit#6827
With some of the new keyboard navigation features, there has been some trouble with the touch experience. This PR reverts a change that no longer checked if a toolbox category was open before setting the selection. Having that check removed was making it so the state was not set correctly and it was not possible to open a single toolbox category back to back with tap. It also adds support for a pointer up event, this fixed the bugs that were happening with the Monaco flyout.
Upload target: https://makecode.microbit.org/app/e532c5c7638ad17654a008d2ab97e2b8e2216b14-a0104c7626