Skip to content

Comments

Config files for automated OSS registration#4380

Merged
guillaumejenkins merged 7 commits intomasterfrom
osscg
May 30, 2018
Merged

Config files for automated OSS registration#4380
guillaumejenkins merged 7 commits intomasterfrom
osscg

Conversation

@guillaumejenkins
Copy link
Contributor

@guillaumejenkins guillaumejenkins commented May 30, 2018

All pxt-core OSS has been registered automatically except Blockly and dapjs, which require manual registration (dapjs isn't in our package-lock.json, and Blockly is not acquired via NPM).

Copy link
Member

@pelikhan pelikhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you document how this stuff works?

@@ -0,0 +1,5 @@
{
"user": "gujenkin",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We typically try to avoid having user names in sources. Can we avoid this?

@guillaumejenkins
Copy link
Contributor Author

@guillaumejenkins guillaumejenkins merged commit 6125fee into master May 30, 2018
@guillaumejenkins guillaumejenkins deleted the osscg branch May 30, 2018 15:34
@lock
Copy link

lock bot commented Sep 26, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Sep 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants