Skip to content

Fix python<->typescript runtime trace tests #6151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
darzu merged 3 commits into from
Nov 1, 2019
Merged

Fix python<->typescript runtime trace tests #6151

darzu merged 3 commits into from
Nov 1, 2019

Conversation

@darzu
Copy link
Contributor

@darzu darzu commented Nov 1, 2019 •
edited
Loading

Fixed three issues:

  • skipLibCheck is necessary for plain TS compilation (sometimes, depending on NPM installs it seems)
  • fix writing an object ([object Object]) instead of typescript code in test case due to "any" type usage
  • fix how we py decompile built-ins like "console.log"

now "jake testtraces" works again

@darzu darzu requested review from riknoll and shakao November 1, 2019 22:37
@darzu darzu merged commit f6582e3 into master Nov 1, 2019
@darzu darzu deleted the dazuniga/fix_tracetests branch November 1, 2019 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pelikhan pelikhan pelikhan approved these changes

@shakao shakao Awaiting requested review from shakao

@riknoll riknoll Awaiting requested review from riknoll

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@darzu @pelikhan