Enable undo button on project load #6161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwunderl
approved these changes
Nov 4, 2019
pelikhan
approved these changes
Nov 4, 2019
shakao
added a commit
that referenced
this pull request
Nov 4, 2019
shakao
added a commit
that referenced
this pull request
Nov 4, 2019
shakao
added a commit
that referenced
this pull request
Nov 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/microsoft/pxt-minecraft/issues/1336, where "undo" is disabled by default and the editor buttons don't re-render on workspace drag. Rather than forcing a re-render, we just enable the undo button when the user has no actions. It will be disabled as usual if the user has performed actions & reached the end of the undo stack.