Skip to content

Conversation

@ganicke
Copy link
Collaborator

@ganicke ganicke commented Nov 26, 2019

A few edits for the blocks-embed page.

RE: #6262

}, "@homeurl@");
```

* [HTML only](https://jsfiddle.net/L8msdjpu/3/)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does "HTML only" mean? - "An HTML render example of an embedded project"?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meaning a basic example without using any kind of JS framework

type: "renderblocks",
id: pre.id,
code: pre.innerText,
code: "",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leave the code attribute blank?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes by design

@ganicke ganicke requested a review from pelikhan November 26, 2019 22:39
@pelikhan pelikhan merged commit 1bb3782 into master Nov 26, 2019
@pelikhan pelikhan deleted the embed-projects-edit branch November 26, 2019 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants